move telemetry code to helix-telemetry project #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 71 out of 74 changed files in this pull request and generated no comments.
Files not reviewed (3)
- pre-commit-hook: Language not supported
- setup.cfg: Language not supported
- spark.Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
spark_pipeline_framework/progress_logger/progress_logger.py:51
- The stub implementations for mlflow methods (such as log_metric, log_param, and log_artifact) are now replaced with 'pass', which may lead to silent failures if these methods are still called. If mlflow integration is no longer needed, consider removing these methods and all associated mlflow configuration to prevent confusion.
pass
spark_pipeline_framework/register.py:4
- [nitpick] Since register() is invoked in multiple locations throughout the codebase, ensure that its implementation is idempotent so that repeated calls do not lead to unintended side effects.
def register() -> None:
gagan-chawla
approved these changes
Apr 8, 2025
spark_pipeline_framework/transformers/fhir_receiver/v1/fhir_receiver_helpers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 73 out of 76 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- pre-commit-hook: Language not supported
- setup.cfg: Language not supported
- spark.Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
spark_pipeline_framework/transformers/fhir_receiver/v1/fhir_receiver_helpers.py:1090
- [nitpick] The variable name 'resources1' is ambiguous; consider renaming it to a more descriptive name such as 'fhir_resources' to improve clarity.
resources1: FhirResourceList = result.get_resources()
spark_pipeline_framework/progress_logger/progress_logger_run.py:42
- [nitpick] The removal of 'end_mlflow_run' logic (replaced by 'pass') might lead to silent failures if MLflow run termination is still expected. Consider adding a clarifying comment or alternate logic if this removal is intentional.
pass
| "sqlalchemy>=1.4.37", | ||
| "sqlparse>=0.5.3", | ||
| "bounded-pool-executor>=0.0.3", | ||
| "fastjsonschema>=2.18.0", | ||
| "helix.fhir.client.sdk>=3.0.38", | ||
| "helix.fhir.client.sdk>=4.1.0", |
There was a problem hiding this comment.
The PR description indicates an upgrade to version 4.0.3 of helix.fhir.client.sdk, but setup.py specifies '>=4.1.0'. Please confirm and align the intended version.
Suggested change
| "helix.fhir.client.sdk>=4.1.0", | |
| "helix.fhir.client.sdk>=4.0.3", |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
Updated dependencies:
helix.fhir.client.sdkfrom 3.0.38 to 4.0.3helixtelemetrypackage (version 1.0.0)Telemetry-related changes:
spark_pipeline_framework/utilities/telemetry/directoryhelixtelemetryhelixtelemetryinstead of local telemetry modulesCode Review Comments:
The changes look clean and systematic. The project is migrating from a custom telemetry implementation to using the
helixtelemetrypackage.The dependency changes make sense:
The import replacements are consistent across files: